Run workflows in Mono Docker containers #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DasSkelett
added
Enhancement
This comment has been minimized.
This comment has been minimized.
|
Well, that was fast 😮 Added the |
DasSkelett
force-pushed
the
feature/workflow-in-container
branch
from
eb0cdc5 to
90b0480
Compare
Almost...
|
|
Hmm, I could either specify the mono version directly in the |
|
This is really neat! That makes the builds way faster and less prone to issues with installing all the mono packages across so many versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The CI builds still take quite a long time to finish, since installing Mono takes around 10 minutes.
@techman83 had the excellent idea of running the builds in Docker containers from the images published here.
Downloading the images should be way faster than installing and pre-compiling it.
Changes
There exists a
containerkeyword for workflow jobs: https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idcontainerIf I understood the documentation correctly, it makes all steps of this job run in the specified container after pulling it from the Docker hub.
Let's see if it works.
Also realized that I messed up the Discord notifications in #3089 since the env var is named differently.